Changeset 625 in xtideuniversalbios for trunk/Assembly_Library/Src/Menu/Dialog/ItemLineSplitter.asm

Timestamp:

Feb 19, 2023, 9:26:52 PM (2 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Added a configuration option to let the BIOS store RamVars to an UMB when Full operating mode is enabled. This is primarily for XT class machines with RAM in the UMA (which apparently is a common thing these days).
• Added two new builds specifically for IBM PS/2 machines. This is for support of the new McIDE adapter from the guys at zzxio.com. Note that the additional hardware specific code (under the USE_PS2 define) is for the PS/2 machines themselves and not for the McIDE adapters, so any controller in an IBM PS/2 machine can be used with the USE_PS2 define.
• Moved pColorTheme out of the range of ROMVARS being copied over when doing "Load old settings from EEPROM" in XTIDECFG. This fixed a serious bug from r592 where loading a BIOS from file and then loading the old settings from ROM would corrupt 7 bytes of code somewhere in the loaded BIOS.
• Optimizations (speed and size) to the library. Browsing the menus in XTIDECFG should now feel a little less sluggish.
• Hopefully fixed a problem with the PostCommitHook script where it sometimes wouldn't find the CommitInProgress file. I say hopefully because testing this is a nightmare.

File:

• trunk/Assembly_Library/Src/Menu/Dialog/ItemLineSplitter.asm (modified) (4 diffs)

trunk/Assembly_Library/Src/Menu/Dialog/ItemLineSplitter.asm

@@ -4 +4 @@
 ;
 ; XTIDE Universal BIOS and Associated Tools
-; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2013 by XTIDE Universal BIOS Team.
+; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2023 by XTIDE Universal BIOS Team.
 ;
 ; This program is free software; you can redistribute it and/or modify
@@ -51 +51 @@
     call    StringProcess_DSSIwithFunctionInDX
 
-    lea     ax, [bx+1]
+    xchg    bx, ax
+    inc     ax
     eLEAVE_STRUCT   ITEM_LINE_SPLITTER_size
     pop     di
@@ -119 +120 @@
 ProcessCharacterFromStringToSplit:
     cmp     al, ' '
-    ja      SHORT .CheckLineLength
-    mov     di, si              ; DS:DI now points start of new word
-    je      SHORT .CheckLineLength
+    jbe     SHORT .ControlCharacterOrSpace
 
-    cmp     al, LF
-    je      SHORT .ChangeToNextLine
-    cmp     al, CR
-    jne     SHORT .IgnoreUnsupportedControlCharacter
-    xor     cx, cx              ; Carriage return so reset line length so far
-
-ALIGN JUMP_ALIGN
 .CheckLineLength:
     cmp     [bp+ITEM_LINE_SPLITTER.wMaxTextLineLength], cx
     jb      SHORT .ChangeToNextLine
-    ret     ; With CF cleared
+    ret                             ; With CF cleared
 
 ALIGN JUMP_ALIGN
@@ -140 +132 @@
     je      SHORT .WantedLineFound
 
-    inc     bx                  ; Increment line
-    xor     cx, cx              ; Zero character counter (and clear CF)
-    mov     si, di              ; Start from complete word
+    inc     bx                      ; Increment line
+    mov     si, di                  ; Start from complete word
     mov     [bp+ITEM_LINE_SPLITTER.wStartOfLine], di
+.CarriageReturn:
+    xor     cx, cx                  ; Zero character counter (and clear CF)
     ret
 
 ALIGN JUMP_ALIGN
-.IgnoreUnsupportedControlCharacter:
+.ControlCharacterOrSpace:
+    mov     di, si                  ; DS:DI now points start of new word
+    je      SHORT .CheckLineLength  ; Jump if space
+    cmp     al, LF
+    je      SHORT .ChangeToNextLine
+    cmp     al, CR
+    je      SHORT .CarriageReturn   ; Reset line length
+    ; Unsupported control character - ignore it
     dec     cx
     clc