Changeset 625 in xtideuniversalbios for trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm

Timestamp:

Feb 19, 2023, 9:26:52 PM (2 years ago)

Author:

Krister Nordvall

Message:

Changes:

• Added a configuration option to let the BIOS store RamVars to an UMB when Full operating mode is enabled. This is primarily for XT class machines with RAM in the UMA (which apparently is a common thing these days).
• Added two new builds specifically for IBM PS/2 machines. This is for support of the new McIDE adapter from the guys at zzxio.com. Note that the additional hardware specific code (under the USE_PS2 define) is for the PS/2 machines themselves and not for the McIDE adapters, so any controller in an IBM PS/2 machine can be used with the USE_PS2 define.
• Moved pColorTheme out of the range of ROMVARS being copied over when doing "Load old settings from EEPROM" in XTIDECFG. This fixed a serious bug from r592 where loading a BIOS from file and then loading the old settings from ROM would corrupt 7 bytes of code somewhere in the loaded BIOS.
• Optimizations (speed and size) to the library. Browsing the menus in XTIDECFG should now feel a little less sluggish.
• Hopefully fixed a problem with the PostCommitHook script where it sometimes wouldn't find the CommitInProgress file. I say hopefully because testing this is a nightmare.

File:

• trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm (modified) (6 diffs)

trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm

@@ -4 +4 @@
 ;
 ; XTIDE Universal BIOS and Associated Tools
-; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2013 by XTIDE Universal BIOS Team.
+; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2023 by XTIDE Universal BIOS Team.
 ;
 ; This program is free software; you can redistribute it and/or modify
@@ -89 +89 @@
 ProgressEventHandler:
     jmp     [cs:bx+.rgfnEventHandlers]
-
-
-ALIGN JUMP_ALIGN
-.InitializeMenuinitFromDSSI:
-    mov     ax, NO_ITEM_HIGHLIGHTED
-    call    Dialog_EventInitializeMenuinitFromDSSIforSingleItemWithHighlightedItemInAX
-    lds     si, [bp+DIALOG.fpDialogIO]
-    call    TimerTicks_ReadFromBdaToAX
-    mov     [si+PROGRESS_DIALOG_IO.wStartTimeTicks], ax
-
-    ; 0 = 65536 but it needs to be adjusted to 65535 to prevent division by zero
-    cmp     WORD [si+PROGRESS_DIALOG_IO.wMaxProgressValue], BYTE 0
-    jne     SHORT CalculateProgressNeededBeforeUpdatingCharacter
-    dec     WORD [si+PROGRESS_DIALOG_IO.wMaxProgressValue]
-    jmp     SHORT CalculateProgressNeededBeforeUpdatingCharacter
 
 
@@ -153 +138 @@
 
 
+ALIGN JUMP_ALIGN
+.InitializeMenuinitFromDSSI:
+    mov     ax, NO_ITEM_HIGHLIGHTED
+    call    Dialog_EventInitializeMenuinitFromDSSIforSingleItemWithHighlightedItemInAX
+    lds     si, [bp+DIALOG.fpDialogIO]
+    call    TimerTicks_ReadFromBdaToAX
+    mov     [si+PROGRESS_DIALOG_IO.wStartTimeTicks], ax
+
+    ; 0 = 65536 but it needs to be adjusted to 65535 to prevent division by zero
+    cmp     WORD [si+PROGRESS_DIALOG_IO.wMaxProgressValue], BYTE 0
+    jne     SHORT CalculateProgressNeededBeforeUpdatingCharacter
+    dec     WORD [si+PROGRESS_DIALOG_IO.wMaxProgressValue]
+    ; Fall to CalculateProgressNeededBeforeUpdatingCharacter
+
 ;--------------------------------------------------------------------
 ; CalculateProgressNeededBeforeUpdatingCharacter
@@ -163 +162 @@
 ;       AX, BX, DX, SI, DS
 ;--------------------------------------------------------------------
-ALIGN JUMP_ALIGN
 CalculateProgressNeededBeforeUpdatingCharacter:
     call    MenuLocation_GetMaxTextLineLengthToAX
@@ -216 +214 @@
 ALIGN JUMP_ALIGN
 .RepeatProgressCharacterCXtimesFromAL:
-    jcxz    NothingToRepeat
     JMP_DISPLAY_LIBRARY PrintRepeatedCharacterFromALwithCountInCX
 
@@ -233 +230 @@
     mov     bx, [si+PROGRESS_DIALOG_IO.wMaxProgressValue]
     sub     bx, [si+PROGRESS_DIALOG_IO.wMinProgressValue]
-NothingToRepeat:
     ret