Changeset 621 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/VariablesAndDPTs/FindDPT.asm

Timestamp:

Nov 21, 2021, 2:15:32 PM (2 years ago)

Author:

krille_n_

Message:

Changes:

• Fixed three different bugs all causing the boot menu to show drives using IRQs even though the BIOS had been built without MODULE_IRQ.
• Fixed two bugs in XTIDECFG where loading a BIOS from file and then loading the old settings from EEPROM would
  • overwrite ROMVARS.wFlags in the loaded BIOS file (in RAM). The possibly resulting mismatch of module flags could make it impossible to change settings for modules included in the BIOS or allow changing settings for modules not included in the BIOS.
  • not copy the color theme over to the loaded BIOS.
• Also fixed two very minor bugs in XTIDECFG in BiosFile_LoadFileFromDSSItoRamBuffer and BiosFile_SaveRamBufferToFileInDSSI where the error handling in these routines would close whatever file handle that happened to match the error code returned by DOS in AX.
• Made significant changes to the new flash ROM programming routines to reduce the size. Also fixed a minor bug that would cause the second verification to be skipped and return success when programming a 64 KB block of data.
• Changed the custom BIOS build file names to the 8.3 format.
• Changed some help strings in XTIDECFG to clarify things.
• Other minor optimizations and fixes.

File:

• trunk/XTIDE_Universal_BIOS/Src/VariablesAndDPTs/FindDPT.asm (modified) (4 diffs)

trunk/XTIDE_Universal_BIOS/Src/VariablesAndDPTs/FindDPT.asm

@@ -137 +137 @@
 ;--------------------------------------------------------------------
 ; Iteration routines for FindDPT_MasterOrSingleForIdevarsOffsetInDL and
-; FindDPT_SlaveForIdevarsOffsetInDL, for use with IterateAllDPTs
+; FindDPT_SlaveForIdevarsOffsetInDL, for use with FindDPT_IterateAllDPTs
 ;
 ; Returns when DPT is found on the controller with Idevars offset in DL
@@ -152 +152 @@
 IterateFindSecondDPTforIdevars:
     call    IterateFindFirstDPTforIdevars
-    jc      SHORT .WrongController
+    jc      SHORT WrongController
     mov     si, IterateFindFirstDPTforIdevars
-.WrongController:
+SetCFandReturn:
     stc
+WrongController:
     ret
 
 IterateFindFirstDPTforIdevars:
     cmp     dl, [di+DPT.bIdevarsOffset]         ; Clears CF if matched
-    je      .Done
-    stc                                         ; Set CF for not found
-.Done:
+    jne     SHORT SetCFandReturn
     ret
 
@@ -221 +220 @@
 ;               Set if DPT not found, or no DPTs present
 ;   Corrupts registers:
-;       SI
+;       BL, SI
 ;--------------------------------------------------------------------
 %ifdef MODULE_SERIAL
@@ -315 +314 @@
     loop    .LoopWhileDPTsLeft
 
-ALIGN JUMP_ALIGN
 .NotFound:
     stc