Changeset 605 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/BootMenuSettingsMenu.asm

Timestamp:

May 8, 2021, 6:55:56 PM (3 years ago)

Author:

krille_n_

Message:

Changes:

• The "Remove other hard drives" option in the Boot settings menu in XTIDECFG is now exposed in all BIOS builds. This is needed because the system BIOS in at least two Zenith computer models (Z-161 and Z-171) does not clear the BDA HD count which causes it to increment on warm boot. Running "Auto Configure" in XTIDECFG now also tries to identify these machines by doing a CRC check on the system BIOS and sets the option to YES if a match is found.
• WORD_ALIGN is now 2 for XT builds. This should benefit XT class machines with 8086 and NEC V30 CPU:s and the cost is negligible (1 byte for the XT BIOS builds and 12 bytes for XTIDECFG.COM).
• Other minor optimizations.

File:

• trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/BootMenuSettingsMenu.asm (modified) (5 diffs)

trunk/XTIDE_Universal_BIOS_Configurator_v2/Src/Menupages/BootMenuSettingsMenu.asm

@@ -142 +142 @@
     at  MENUITEM.szQuickInfo,       dw  g_szNfoClearBdaDriveCount
     at  MENUITEM.szHelp,            dw  g_szHelpClearBdaDriveCount
-    at  MENUITEM.bFlags,            db  FLG_MENUITEM_FLAGVALUE
+    at  MENUITEM.bFlags,            db  FLG_MENUITEM_VISIBLE | FLG_MENUITEM_FLAGVALUE
     at  MENUITEM.bType,             db  TYPE_MENUITEM_MULTICHOICE
     at  MENUITEM.itemValue + ITEM_VALUE.wRomvarsValueOffset,        dw  ROMVARS.wFlags
@@ -148 +148 @@
     at  MENUITEM.itemValue + ITEM_VALUE.szMultichoice,              dw  g_szMultichoiceBooleanFlag
     at  MENUITEM.itemValue + ITEM_VALUE.rgszValueToStringLookup,    dw  g_rgszValueToStringLookupForFlagBooleans
-    at  MENUITEM.itemValue + ITEM_VALUE.wValueBitmask,              dw  FLG_ROMVARS_IGNORE_MOTHERBOARD_DRIVES
+    at  MENUITEM.itemValue + ITEM_VALUE.wValueBitmask,              dw  FLG_ROMVARS_CLEAR_BDA_HD_COUNT
 iend
 
@@ -258 +258 @@
     call    .EnableOrDisableColorThemeSelection
     call    .EnableOrDisableBootMenuSelectionTimeout
-    call    .EnableOrDisableClearBdaDriveCount
     mov     si, g_MenupageForBootMenuSettingsMenu
     jmp     Menupage_ChangeToNewMenupageInDSSI
@@ -328 +327 @@
     mov     bx, g_MenuitemBootMnuStngsSelectionTimeout
     test    ax, FLG_ROMVARS_MODULE_BOOT_MENU
-    jmp     SHORT .DisableMenuitemFromCSBXifZFset
-
-
-;--------------------------------------------------------------------
-; .EnableOrDisableClearBdaDriveCount
-;   Parameters:
-;       AX:     ROMVARS.wFlags
-;       SS:BP:  Menu handle
-;   Returns:
-;       Nothing
-;   Corrupts registers:
-;       BX
-;--------------------------------------------------------------------
-ALIGN JUMP_ALIGN
-.EnableOrDisableClearBdaDriveCount:
-    mov     bx, g_MenuitemBootMnuStngsClearBdaDriveCount
-    call    Buffers_IsXTbuildLoaded
 .DisableMenuitemFromCSBXifZFset:
     jz      SHORT .DisableMenuitemFromCSBX
@@ -448 +430 @@
     mov     cx, ATTRIBUTE_CHARS_size
     mul     cl                          ; Multiply with the menu choice index
-    mov     si, ColorThemeTable
-    add     si, ax
-    mov     ax, [es:di]                 ; Fetch the ptr to ColorTheme
+    mov     si, [es:di]                 ; Fetch the ptr to ColorTheme
+    add     ax, ColorThemeTable
+    xchg    si, ax
     mov     di, ax