Changeset 491 in xtideuniversalbios for trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH1Eh_XTCF.asm

Timestamp:

Dec 15, 2012, 2:46:29 PM (12 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes:

• Added a new define (USE_UNDOC_INTEL) that enables optimizations possible by using undocumented instructions available on all Intel processors and truly compatible clones. AFAIK the only exceptions are the NEC V-series and the Sony CXQ70108 processors so this option should be safe for use on the AT builds.
• Building BIOSDRVS or the BIOS without MODULE_STRINGS_COMPRESSED would fail due to the recent code exclusions so I changed them a bit. Also fixed the mistaken change to Main.asm
• Changed the Tandy specific info in Configuration_FullMode.txt so it matches the info in the Wiki.
• Optimizations and fixes in general.

File:

• trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH1Eh_XTCF.asm (modified) (6 diffs)

trunk/XTIDE_Universal_BIOS/Src/Handlers/Int13h/AH1Eh_XTCF.asm

@@ -3 +3 @@
 
 ;
-; XTIDE Universal BIOS and Associated Tools 
+; XTIDE Universal BIOS and Associated Tools
 ; Copyright (C) 2009-2010 by Tomi Tilli, 2011-2012 by XTIDE Universal BIOS Team.
 ;
@@ -10 +10 @@
 ; the Free Software Foundation; either version 2 of the License, or
 ; (at your option) any later version.
-; 
+;
 ; This program is distributed in the hope that it will be useful,
 ; but WITHOUT ANY WARRANTY; without even the implied warranty of
 ; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-; GNU General Public License for more details.      
+; GNU General Public License for more details.
 ; Visit http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
-;       
+;
 
 ; Section containing code
@@ -63 +63 @@
     call    AccessDPT_IsThisDeviceXTCF
     jne     SHORT XTCFnotFound
-    and     ax, BYTE 7Fh                ; Subcommand now in AX
+    and     ax, BYTE 7Fh                ; Subcommand now in AX (clears AH and CF)
     jz      SHORT .ReturnWithSuccess    ; IS_THIS_DRIVE_XTCF
 
@@ -70 +70 @@
     jnz     SHORT .SkipReadXtcfControlRegisterToDH
     mov     dx, [di+DPT.wBasePort]
-    add     dl, XTCF_CONTROL_REGISTER
+    add     dl, XTCF_CONTROL_REGISTER   ; Will never overflow (keeps CF cleared)
     in      al, dx
     mov     [bp+IDEPACK.intpack+INTPACK.dh], al
 .ReturnWithSuccess:
-    xor     ah, ah
-    ret
+    ret     ; With AH and CF cleared
+
 .SkipReadXtcfControlRegisterToDH:
-
     ; WRITE_DH_TO_XTCF_CONTROL_REGISTER
     dec     ax                          ; Subcommand
@@ -122 +121 @@
     mov     BYTE [di+DPT_ATA.bDevice], DEVICE_8BIT_XTCF_PIO8
     ; Fall to .Enable8bitPioMode
-    
+
     ; We always need to enable 8-bit mode since 16-bit mode is restored
-    ; when controller is reset (AH=0h or Dh)
-.Enable8bitPioMode: 
+    ; when controller is reset (AH=00h or 0Dh)
+.Enable8bitPioMode:
     jmp     AH23h_Enable8bitPioMode
 
@@ -143 +142 @@
 AH1Eh_DetectXTCFwithBasePortInDX:
     push    dx
-    add     dl, XTCT_CONTROL_REGISTER_INVERTED_in   ; set DX to XT-CF config register (inverted)
+    add     dl, XTCF_CONTROL_REGISTER_INVERTED_in   ; set DX to XT-CF config register (inverted)
     in      al, dx      ; get value
     mov     ah, al      ; save in ah