Changeset 181 in xtideuniversalbios for trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm

Timestamp:

Nov 13, 2011, 3:38:40 PM (13 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Changes to all parts of the project:

• Size optimizations.
• Added a define (EXCLUDE_FROM_XTIDECFG) to exclude unused library code from XTIDECFG.
• Tried to minimize time spent with interrupts disabled.
• Some minor attempts to improve speed (reordering instructions etc).
• Tried to improve readability, did some cleanup and fixed some errors in comments.

File:

• trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm (modified) (6 diffs)

trunk/Assembly_Library/Src/Menu/Dialog/DialogProgress.asm

@@ -1 @@
-; File name     :   DialogProgress.asm
 ; Project name  :   Assembly Library
-; Created date  :   15.8.2010
-; Last update   :   10.12.2010
-; Author        :   Tomi Tilli
 ; Description   :   Displays progress bar dialog and starts progress task.
 
@@ -41 +37 @@
     lds     si, [bp+DIALOG.fpDialogIO]
     mov     bx, [si+PROGRESS_DIALOG_IO.wMaxProgressValue]
-    MIN_U   ax, bx
-    cmp     ax, bx  ; Make sure that last progress character is shown
-    je      SHORT .UpdateProgressBar
-
+    cmp     ax, bx
+    jb      SHORT .AXlessThanBX
+    mov     ax, bx
+    jmp     SHORT .UpdateProgressBar
+ALIGN JUMP_ALIGN
+.AXlessThanBX:
     mov     bx, ax
     sub     bx, [si+PROGRESS_DIALOG_IO.wCurrentProgressValue]
@@ -172 +170 @@
 ALIGN JUMP_ALIGN
 DrawProgressBarFromDialogIoInDSSI:
-    call    .GetFullCharsToCXandEmptyCharsToDXwithDialogIoInDSSI
-
-    mov     al, PROGRESS_COMPLETE_CHARACTER
-    call    .RepeatProgressCharacterCXtimesFromAL
-
-    mov     cx, dx
-    mov     al, PROGRESS_INCOMPLETE_CHARACTER
-    jmp     SHORT .RepeatProgressCharacterCXtimesFromAL
-
-;--------------------------------------------------------------------
-; .GetFullCharsToCXandEmptyCharsToDXwithDialogIoInDSSI
-;   Parameters:
-;       DS:SI:  Ptr to PROGRESS_DIALOG_IO
-;       SS:BP:  Ptr to DIALOG
-;   Returns:
-;       CX:     Number of full progress bar characters
-;       DX:     Number of empty progress bar characters
-;   Corrupts:
-;       AX, BX
-;--------------------------------------------------------------------
-ALIGN JUMP_ALIGN
-.GetFullCharsToCXandEmptyCharsToDXwithDialogIoInDSSI:
+    ; Get full chars to CX and empty chars to DX
     call    MenuLocation_GetMaxTextLineLengthToAX
     mov     cx, ax
@@ -200 +177 @@
     div     bx
     xchg    cx, ax      ; AX = Text line length, CX = Number of full chars
-
     sub     ax, cx
     xchg    dx, ax      ; DX = Number of empty chars
-    ret
+
+    mov     al, PROGRESS_COMPLETE_CHARACTER
+    call    .RepeatProgressCharacterCXtimesFromAL
+
+    mov     cx, dx
+    mov     al, PROGRESS_INCOMPLETE_CHARACTER
+    ; Fall to .RepeatProgressCharacterCXtimesFromAL
 
 ;--------------------------------------------------------------------
@@ -239 +221 @@
     ret
 
-    
+
 ;--------------------------------------------------------------------
 ; DrawTimeElapsedFromDX
@@ -286 +268 @@
 
     sub     cx, [si+PROGRESS_DIALOG_IO.wMinProgressValue]
-    jcxz    .PreventDivisionByZero
+    jz      SHORT .PreventDivisionByZero
     div     cx          ; AX = Estimated ticks left
     xchg    dx, ax
-    jmp     SHORT FormatTicksFromDX
+    SKIP2B  f   ; cmp ax, <next instruction>
 .PreventDivisionByZero:
     xor     dx, dx