Changeset 145 in xtideuniversalbios for trunk/Configurator/Src/BiosFile.asm

Timestamp:

Mar 15, 2011, 11:28:17 AM (14 years ago)

Author:

krille_n_@…

google:author:

krille_n_@hotmail.com

Message:

Minor size optimizations to all parts of the project (even the old Configurator).
Also added a new 'release' option to the makefiles of both versions of the Configurator. It invokes UPX and makes the Configurator programs ridiculously tiny.

File:

• trunk/Configurator/Src/BiosFile.asm (modified) (2 diffs)

trunk/Configurator/Src/BiosFile.asm

@@ -1 @@
-; File name     :   EEPROM.asm
 ; Project name  :   XTIDE Univeral BIOS Configurator
-; Created date  :   20.4.2010
-; Last update   :   21.4.2010
-; Author        :   Tomi Tilli
 ; Description   :   Functions for loading and saving BIOS image file.
 
@@ -154 +150 @@
 ;               Cleared if supported size
 ;   Corrupts registers:
-;       DX
+;       Nothing
 ;--------------------------------------------------------------------
 ALIGN JUMP_ALIGN
 BiosFile_GetFileSizeToCX:
-    mov     cx, [si+DTA.dwFileSize]
-    mov     dx, [si+DTA.dwFileSize+2]
-    test    dx, dx                      ; More than 65535 bytes?
+    mov     cx, [si+DTA.dwFileSize+2]   ; High word of file size to CX
+    test    cx, cx                      ; File larger than 65535 bytes? (clears CF)
+    mov     cx, [si+DTA.dwFileSize]     ; Low word of file size to CX
     jnz     SHORT .TooLargeFile
     cmp     cx, MAX_EEPROM_SIZE         ; Too large?
     ja      SHORT .TooLargeFile
-    clc
-    ret
-.TooLargeFile:
     stc
+.TooLargeFile:                          ; CF is always cleared when jumping to here
+    cmc                                 ; So we invert it
     ret